Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svg for X #1273

Merged
merged 7 commits into from
Nov 4, 2023
Merged

Add svg for X #1273

merged 7 commits into from
Nov 4, 2023

Conversation

zanseb
Copy link
Contributor

@zanseb zanseb commented Jul 27, 2023 •
edited
Loading

Add svg for X https://x.com formerly known as twitter.

image
image

@Mombuyish
Copy link

Good work! but you are missing share button and settings in config file, can you fix it?

@zanseb
Copy link
Contributor Author

zanseb commented Jul 30, 2023

image
image

@zanseb
Copy link
Contributor Author

zanseb commented Jul 30, 2023

What should I add to the config file?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Mombuyish
Copy link

What should I add to the config file?

Sorry I mean you should update the sample site and wiki config.

https://github.com/adityatelange/hugo-PaperMod/blob/exampleSite/config.yml
https://github.com/adityatelange/hugo-PaperMod/wiki

it's really helpful that this PR. Thank you.

@zanseb
Copy link
Contributor Author

zanseb commented Aug 2, 2023 •
edited
Loading

Oh ok. I can provide you a patch for the wiki:
0001-Document-X-social-icon.patch

I'll create a separate PR for the demo site.

@zanseb zanseb mentioned this pull request Aug 2, 2023
Merged
@zanseb
Copy link
Contributor Author

zanseb commented Aug 2, 2023

Ok done. I hope I did everything correctly 🙂

@adityatelange
Copy link
Owner

we'll wait until x.com is live

@adityatelange adityatelange added the enhancement New feature or improvement label Aug 5, 2023
@nielsbrakel
Copy link

@adityatelange Can this be merged?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 50cafe4 into adityatelange:master Nov 4, 2023
2 checks passed
ajleitzke added a commit to ajleitzke/hugo-PaperMod that referenced this pull request Nov 10, 2023
@ajleitzke @coxde
@NhanAZ @larskristianhaga @thanosapollo @kev-odin @adityatelange @zanseb
Update (#1)
f87125e 
* Add the social icon for Firefish (adityatelange#1294)

* Add social icon for Pleroma (adityatelange#1293)

* Update vi.yaml (adityatelange#1316)

* Added Norwegian translation (adityatelange#1318)

* Add codeberg icon (adityatelange#1310)

Resolve adityatelange#1268

* Add Swahili translation sw.yaml (adityatelange#1303)

Co-authored-by: dryscord <[email protected]>

* feat: add bugcrowd and intigriti to svg.html (adityatelange#1205)

* Update README.md

Mention Paper's commit sha

* Add `safeHTML` to post_meta
- delimit now returns a string and not a template.HTML from hugo v0.120.0
- no impact found with min req version for Papermod
https://github.com/gohugoio/hugo/releases/tag/v0.120.0

fixes adityatelange#1325

* Add X icon in Share and Social buttons (replaces twitter share icon) (adityatelange#1273)

* Add svg for X

* Add X share button

* Remove twitter share button

* Add backwards compatibility for twitter share button

* simplify condition

* alphabetize x svg

---------

Co-authored-by: Aditya Telange <[email protected]>

* Error out if hugo.Version used is less than min required version

---------

Co-authored-by: COxDE <[email protected]>
Co-authored-by: Thành Nhân <[email protected]>
Co-authored-by: Lars Kristian Haga <[email protected]>
Co-authored-by: Thanos Apollo <[email protected]>
Co-authored-by: calalloo <[email protected]>
Co-authored-by: dryscord <[email protected]>
Co-authored-by: Kevin Chung <[email protected]>
Co-authored-by: Aditya Telange <[email protected]>
Co-authored-by: Sebastian Zanoni <[email protected]>
zer0ttl pushed a commit to zer0ttl/hugo-PaperMod that referenced this pull request Jan 24, 2024
@zanseb @adityatelange
Add X icon in Share and Social buttons (replaces twitter share icon) (a…
a5e8cbd 
…dityatelange#1273)

* Add svg for X

* Add X share button

* Remove twitter share button

* Add backwards compatibility for twitter share button

* simplify condition

* alphabetize x svg

---------

Co-authored-by: Aditya Telange <[email protected]>
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
@zanseb @adityatelange
Add X icon in Share and Social buttons (replaces twitter share icon) (a…
3cb82cf 
…dityatelange#1273)

* Add svg for X

* Add X share button

* Remove twitter share button

* Add backwards compatibility for twitter share button

* simplify condition

* alphabetize x svg

---------

Co-authored-by: Aditya Telange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zanseb @Mombuyish @adityatelange @nielsbrakel