Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raycast logo #1435

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add raycast logo #1435

merged 3 commits into from
Mar 7, 2024

Conversation

nagauta
Copy link
Contributor

@nagauta nagauta commented Feb 24, 2024

What does this PR change? What problem does it solve?
there is no icon support for raycast so i wanna add the icon.
I use the icon from brand guideline
スクリーンショット 2024-02-24 15 18 04

Was the change discussed in an issue or in the Discussions before?
I have not discussed.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@nagauta nagauta changed the title add raycast logo Adding raycast logo Feb 24, 2024
@nagauta nagauta marked this pull request as draft February 24, 2024 06:29
@nagauta
Copy link
Contributor Author

nagauta commented Feb 24, 2024

@adityatelange
Hi, thanks for creating cool theme.

I'd love to add icon of rayacst.
should I modify this icon to fit theme right?

@adityatelange
Copy link
Owner

adityatelange commented Mar 2, 2024

I'd love to add icon of rayacst. should I modify this icon to fit theme right?

Yes please. But does raycast have a user profile page?

@nagauta
Copy link
Contributor Author

nagauta commented Mar 3, 2024

I'm working on it!
Yes, raycast have a user profile page like below.
https://www.raycast.com/nagauta

@nagauta nagauta changed the title Adding raycast logo Add raycast logo Mar 3, 2024
@nagauta nagauta marked this pull request as ready for review March 3, 2024 11:25
Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nagauta
Copy link
Contributor Author

nagauta commented Mar 3, 2024

I modified logo to fit theme, please review this

light mode

スクリーンショット 2024-03-03 20 25 24

##. dark mode
スクリーンショット 2024-03-03 20 26 15

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adityatelange adityatelange merged commit 6e958e7 into adityatelange:master Mar 7, 2024
1 check passed
ayedaemon pushed a commit to ayedaemon/hugo-PaperMod that referenced this pull request Mar 27, 2024
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
nsrahmad pushed a commit to nsrahmad/hugo-PaperMod that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants