sbJson reader execution fail tests

[stansmith907]

Some sbJson input is failing due to tests in the sbJson reader. These are the current tests. We should decide which should remain in the code.

• contact.contactName missing
• contact.contactType missing
• contact.contactType not [ 'person' | 'organization' ]
• weblink.uri missing
• weblink.type missing Note: weblinks of type = 'browseImage' are placed in browseGraphic objects, all others are placed in additionalDocument.citation.onlineResource objects.
• weblink.type missing Alternative: place all non-browseImage weblink types, including nil in additional documents.

[dwalt]

What is contact type and weblink type?

…

On Mon, Oct 2, 2017 at 10:35 AM, stansmith907 ***@***.***> wrote: Some sbJson input is failing due to tests in the sbJson reader. These are the current tests. We should decide which should remain in the code. - contact.contactName missing - contact.contactType missing - contact.contactType not [ 'person' | 'organization' ] - weblink.uri missing - weblink.type missing Note: weblinks of type = 'browseImage' are placed in browseGraphic objects, all others are placed in additionalDocument.citation.onlineResource objects. - weblink.type missing Alternative: place all non-browseImage weblink types, including nil in additional documents. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#146>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF6hLxWljmuvG4n5gvlbybKH3NAjbTt9ks5soSzwgaJpZM4PrD-6> .

[stansmith907]

Consensus from group meeting:

• If contact.contactName missing - drop contact record and continue processing
• If contact.contactType missing - default contactType to person
• If weblink.uri missing - drop weblink and continue processing
• unless weblink.type is 'browseImage' - process as additionalDocument