Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest Set tag for sbJSON should include the title only #150

Closed
jlblcc opened this issue Oct 12, 2017 · 2 comments
Closed

Harvest Set tag for sbJSON should include the title only #150

jlblcc opened this issue Oct 12, 2017 · 2 comments
Labels
bug Unexpected problem or unintended behavior writer:sbJson

Comments

@jlblcc
Copy link
Member

jlblcc commented Oct 12, 2017

We shouldn't concatenate the repository name in the value for the "name". See: https://github.com/adiwg/mdTranslator/blob/master/lib/adiwg/mdtranslator/writers/sbJson/sections/sbJson_tag.rb#L70

Just include the title.
@jlblcc jlblcc added bug Unexpected problem or unintended behavior writer:sbJson labels Oct 12, 2017
@stansmith907
Copy link
Contributor

Okay. However, repository name is required while citation.title is not. Therefore, if citation.title is missing I will drop the tag.

@jlblcc
Copy link
Member Author

jlblcc commented Oct 12, 2017

👍 Main thing is to allow users full control of tag name in the sbJSON output.

stansmith907 added a commit to stansmith907/mdTranslator that referenced this issue Oct 12, 2017
@stansmith907
Remove repository name from harvest set tag in sbJson writer. Closes …
a8f349d 
…issue adiwg#150
@stansmith907 stansmith907 mentioned this issue Oct 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior writer:sbJson
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stansmith907 @jlblcc