Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbJSON writer should only write parentId with proper namespace #154

Closed
jlblcc opened this issue Oct 23, 2017 · 1 comment
Closed

sbJSON writer should only write parentId with proper namespace #154

jlblcc opened this issue Oct 23, 2017 · 1 comment
Assignees
@stansmith907
Labels
bug Unexpected problem or unintended behavior writer:sbJson

Comments

@jlblcc
Copy link
Member

jlblcc commented Oct 23, 2017

We should only write out the parentId if the namespace is 'gov.sciencebase.catalog'. It appears that the first identifier is used if one with the SB namespace is not present. In those instances, it would be better to set parentId to null.

See: https://github.com/adiwg/mdTranslator/blob/master/lib/adiwg/mdtranslator/writers/sbJson/sections/sbJson_parentId.rb#L17
@jlblcc jlblcc added the bug Unexpected problem or unintended behavior label Oct 23, 2017
@jlblcc
Copy link
Member Author

jlblcc commented Oct 23, 2017

To clarify, we should write out the first parentMetadata->identifier with the correct namespace.

stansmith907 added a commit to stansmith907/mdTranslator that referenced this issue Oct 24, 2017
@stansmith907
Bump version to 2.3.6
4856846 
Closes issue adiwg#154
@stansmith907 stansmith907 mentioned this issue Oct 24, 2017
Merged
@jlblcc jlblcc closed this as completed Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stansmith907 stansmith907

Labels
bug Unexpected problem or unintended behavior writer:sbJson
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stansmith907 @jlblcc