Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerated Value lists Description written to the ISO 19110 output? #218

Closed
palmerj opened this issue Nov 3, 2019 · 5 comments
Closed
Assignees

Comments

@palmerj
Copy link

palmerj commented Nov 3, 2019

I tried to translate a valid fgdc XML file to ISO 19110 XML and the enumerated values list descriptions were not being created. See file here https://gist.github.com/palmerj/5b04d52307f2a4d7c991759bc8ce77d9

@jlblcc jlblcc self-assigned this Nov 7, 2019
@jlblcc
Copy link
Member

jlblcc commented Nov 7, 2019

Looks like the FGDC reader is assigning the first overall domain(first domain from first parsed attribute) to each attribute instead of the the first domain assigned to the individual attribute (the mdTranslator and mdJSON spec only support one domain assignment for each attribute).

Will adjust the logic to use the first domain assigned to each individual attribute in FGDC (I would think that having multiple domains assigned to an attribute is more of an edge case, excepting range domains which are handled differently). Look for the patch in v2.17.1. @palmerj Thanks for reporting this.

@palmerj
Copy link
Author

palmerj commented Nov 8, 2019

Thanks heaps @jlblcc

@dwalt
Copy link
Collaborator

dwalt commented Nov 8, 2019 via email

@jlblcc
Copy link
Member

jlblcc commented Nov 8, 2019

@dwalt The FGDC reader handles range domains differently. In fact, they are not interpreted as "domains" at all. The mdJSON schema has the valueRange property which the CSDGM range domains map to. Therefore, if you have a single codeset domain and any number of range domains, you should not lose anything in the translation.

@dwalt
Copy link
Collaborator

dwalt commented Nov 8, 2019 via email

@jlblcc jlblcc closed this as completed in 6e5a517 Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants