Add Geologic Age to timeInstant and timePeriod #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iencebase.catalog'
jlblcc
reviewed
Nov 11, 2017
| aIdentifiers << metadataInfo[:metadataIdentifier] | ||
| end | ||
| end | ||
| # do not duplicate the identifier which is the primary resource |
There was a problem hiding this comment.
This only applies to the metadataIdentifiers with the ScienceBase namespace. Need to check for that here. Otherwise, the uuid metadata identifiers will almost always be left out, since they are the default metadataIds in the mdEditor.
There was a problem hiding this comment.
Nevermind, I see the previous code block takes care of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'description' element to data dictionary
Add 'metadataIdentifier' to sbJson 'identifiers' when namespace not equal 'gov.sciencebase.gov'
Bump version to 2.6.0