Macros #15
Merged
Macros #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses an extra pattern to capture trailing commas. The `$crate` fragment is used to refer to the crate that defines the macro. An absolute path is used to refer to std to avoid local shadowing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution to the Macros exercise.
Mentoring
First iteration
By referencing the excellent Programming Rust book, I could see how to do repeated matching and unrolling, as well as a neat extra case to deal with optional trailing commas. My only question for the mentor was if this is still how one would typically "solve" optional trailing commas for macros that do repeated matching. However, this time, the mentor did not provide any constructive feedback. Unfortunately, they admitted to not having the best understanding of Rust's declarative macros. It took quite some time for any mentor to take up my assignment, so I did not re-submit for additional mentoring. I also think this solution is good, so let's keep swimming.
Abbreviated review comments from the mentor on 3de0415: