Luhn #17
Merged
Luhn #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chars().into_iterator() is unnecessary * so is the second !c.is_ascii_whitespace() filter * simpler return expression with `checksum % 10 == 0` * let-else is a thing since Rust 1.65 * Boxing is_none in a lambda is not needed. I thought that it was since is_none takes a &self, which I typically associate with methods, but rust seems to be able to figure this out.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solutions to the Luhn exercise.
Mentoring
First iteration
I'm happy that I managed to write the
digitscomputation without branches. The mentor had some additional tips, however.Regarding the return expression on :
Also:
Moreover, I became aware of the
let-elsesyntax.second iteration
The discussion with the mentor ended without further comments.