Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-11276: Text component does not appear in the viewport when the 'setFocus' is triggered on the Text Component. #1000

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

AnurudraS
Copy link
Contributor

Description

adding a scroll in view function for text only as text doesn't have any field to apply setActive.
respected test case is also added in the same.

Related Issue

FORMS-11276: Text component does not appear in the viewport when the 'setFocus' is triggered on the Text Component.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 88 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (559cd44) 80.29% compared to head (891351d) 80.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1000   +/-   ##
=========================================
  Coverage     80.29%   80.29%           
  Complexity      729      729           
=========================================
  Files            89       89           
  Lines          2045     2045           
  Branches        271      271           
=========================================
  Hits           1642     1642           
  Misses          251      251           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnurudraS AnurudraS requested a review from barshat7 November 22, 2023 07:28
@AnurudraS AnurudraS merged commit c4f3919 into dev Nov 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants