Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-17559: fix rule-editor test #1492

Merged
merged 19 commits into from
Jan 21, 2025
Merged

FORMS-17559: fix rule-editor test #1492

merged 19 commits into from
Jan 21, 2025

Conversation

arunattri26
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

cy.deleteComponentByPath(buttonEditPath);
})

if (cy.af.isLatestAddon()) {
it('should add validation rule on date fields', function () {
it.skip('should add validation rule on date fields', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have we skipped this test, can you fix this ?

Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@arunattri26 arunattri26 requested a review from rismehta January 21, 2025 04:47
@rismehta rismehta merged commit 0bfda99 into release/650 Jan 21, 2025
6 of 11 checks passed
@rismehta rismehta deleted the FORMS-17559 branch January 21, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants