Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hardening PathUtils.addExtension #55

Merged
merged 2 commits into from
Mar 30, 2021
Merged

fix: Hardening PathUtils.addExtension #55

merged 2 commits into from
Mar 30, 2021

Conversation

SushantBhasin
Copy link
Contributor

Description

  • Updating addExtension method by removing regex and replacing it with functions to extract regex groups

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

sharanyavinod
sharanyavinod approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@sharanyavinod sharanyavinod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Just added a minor suggestion.

@SushantBhasin SushantBhasin merged commit 643f882 into master Mar 30, 2021
github-actions bot pushed a commit that referenced this pull request Mar 30, 2021
@semantic-release-bot
chore(release): 1.3.10 [skip ci]
f8c4be5 
## [1.3.10](v1.3.9...v1.3.10) (2021-03-30)

### Bug Fixes

* Hardening PathUtils.addExtension ([#55](#55)) ([643f882](643f882))
@github-actions
Copy link

🎉 This PR is included in version 1.3.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sharanyavinod sharanyavinod deleted the issue/hardening-pathutils-addExtension branch July 14, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharanyavinod sharanyavinod sharanyavinod approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SushantBhasin @sharanyavinod