Add docs for internal APIs and some cleanup #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdobrin
commented
Feb 3, 2023
| @@ -189,7 +188,6 @@ static final class Identity { | |||
| static final class VisitorID { | |||
|
|
|||
| static final String ID = "ID"; | |||
| static final String ID_ORIGIN = "ID_ORIGIN"; // todo: check this usage | |||
There was a problem hiding this comment.
this key was not read in 1.x either, when serializing the custom ids it uses
static final String VISITOR_ID_PARAMETER_KEY_CUSTOMER = "d_cid_ic";
| @@ -155,7 +155,6 @@ static final class Audience { | |||
|
|
|||
| // response keys | |||
| static final String VISITOR_PROFILE = "aamprofile"; | |||
| static final String AUDIENCE_IDS = "audienceids"; | |||
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.0 #26 +/- ##
=============================================
Coverage 83.99% 83.99%
Complexity 142 142
=============================================
Files 6 6
Lines 612 612
Branches 92 92
=============================================
Hits 514 514
Misses 64 64
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
addb
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: