-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions reusable workflows #62
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #62 +/- ##
==========================================
- Coverage 96.19% 95.90% -0.29%
==========================================
Files 33 33
Lines 2546 2073 -473
==========================================
- Hits 2449 1988 -461
+ Misses 97 85 -12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we change EventHub.reset
to MobileCore.resetSDK
?
https://github.com/timkimadobe/aepsdk-edgemedia-ios/blob/main/Tests/UnitTests/Media%2BPublicAPITests.swift#L22
Thank you, great catch! Updated to use the |
Description
This PR migrates the Edge Media iOS repo to use the reusable workflows from aepsdk-commons for:
Dependency chanages
2.5.23
(latest) (Gemfile.lock)1.16.2
(latest) - Podfile.lock, Gemfile, Gemfile.lockTesting changes
TestBase
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: