Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions reusable workflows #62

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Nov 21, 2024

Description

This PR migrates the Edge Media iOS repo to use the reusable workflows from aepsdk-commons for:

  • Update versions
    • Removal of local version scripts
  • Release
  • Build and test
    • Makefile updates for matrix compatibility and default derived data location logic
    • Splitting test rules into unit, functional, and integration for parallelization

Dependency chanages

  • Updates the gem bundler to2.5.23 (latest) (Gemfile.lock)
  • Update cocoapods to 1.16.2 (latest) - Podfile.lock, Gemfile, Gemfile.lock

Testing changes

  • Update AEPTestUtils to 5.2.2 (Core)
    • Update usage of logging property breaking change in TestBase
  • Updates integration tests to use a longer default timeout for network request assertions to address test flakiness on slower runners

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (d345f22) to head (0b46f90).
Report is 25 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #62      +/-   ##
==========================================
- Coverage   96.19%   95.90%   -0.29%     
==========================================
  Files          33       33              
  Lines        2546     2073     -473     
==========================================
- Hits         2449     1988     -461     
+ Misses         97       85      -12     

Copy link
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timkimadobe
Copy link
Contributor Author

timkimadobe commented Dec 5, 2024

Do we change EventHub.reset to MobileCore.resetSDK? https://github.com/timkimadobe/aepsdk-edgemedia-ios/blob/main/Tests/UnitTests/Media%2BPublicAPITests.swift#L22

Thank you, great catch! Updated to use the MobileCore.resetSDK API instead

@timkimadobe timkimadobe requested a review from cacheung December 5, 2024 00:35
@timkimadobe timkimadobe merged commit f26c8a6 into adobe:dev Dec 5, 2024
16 of 19 checks passed
@timkimadobe timkimadobe deleted the workflow-updates branch December 5, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants