-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for optimize extension #105
base: dev-v3.2.0
Are you sure you want to change the base?
Add unit tests for optimize extension #105
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-v3.2.0 #105 +/- ##
================================================
+ Coverage 82.58% 83.03% +0.45%
- Complexity 206 209 +3
================================================
Files 9 9
Lines 999 1002 +3
Branches 159 159
================================================
+ Hits 825 832 +7
+ Misses 95 92 -3
+ Partials 79 78 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
+ " xcore:offer-activity:1111111111111111/xcore:offer-placement:1111111111111111", | ||
aepOptimizeError.getDetail()); | ||
Assert.assertEquals("Not Found", aepOptimizeError.getTitle()); | ||
extension.clearUpdateRequestEventIdsErrors(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we move extension.clearUpdateRequestEventIdsErrors();
to the @After
block so it is not repeated in every single test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add tests for
- testHandleEdgeErrorResponse_nullRequestEventId
- testHandleEdgeErrorResponse_emptyRequestEventId
- testHandleEdgeErrorResponse_requestEventIdNotBeingTracked
Additionally do you think it makes sense to move the check OptimizeUtils.isNullOrEmpty(event.getEventData())
before we get the requestEventId from the event data. as the first statement in the try block in handleEdgeErrorResponse
?
Description
Adding unit tests for optimize extension
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: