Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to main for 5.0.0 release #80

Merged
merged 21 commits into from
Mar 19, 2024
Merged

Staging to main for 5.0.0 release #80

merged 21 commits into from
Mar 19, 2024

Conversation

cdhoffmann
Copy link
Contributor

@cdhoffmann cdhoffmann commented Mar 18, 2024

Description

Prep for 5.0 release which updates min deployment to iOS 12 and sets Xcode build/release in CI to Xcode 15

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #80 (814672b) into main (5907e2e) will increase coverage by 4.28%.
Report is 32 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   91.69%   95.97%   +4.28%     
==========================================
  Files          17       17              
  Lines         349      472     +123     
==========================================
+ Hits          320      453     +133     
+ Misses         29       19      -10     

@cdhoffmann cdhoffmann requested a review from emdobrin March 18, 2024 22:10
@@ -1,17 +1,14 @@
// swift-tools-version:5.1
// swift-tools-version:5.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.1 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarified this is 5.3 matching core

@cdhoffmann cdhoffmann merged commit 514d2b3 into main Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants