Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev to staging (v2.0.3) #35

Merged
merged 2 commits into from
Jan 26, 2024
Merged

dev to staging (v2.0.3) #35

merged 2 commits into from
Jan 26, 2024

Conversation

swarna04
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…nt data callback (#34)

* Target SDK should attach response tokens in the retrieveLocationContent data callback

* Bumped extension version

* minor fix, testapp and doc updates

* Added additional test

* Fixed failing test

* More test fixes
@swarna04 swarna04 requested a review from sbenedicadb January 26, 2024 22:32
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aff0208) 81.70% compared to head (6133592) 81.84%.

Files Patch % Lines
.../phone/java/com/adobe/marketing/mobile/Target.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging      #35      +/-   ##
===========================================
+ Coverage    81.70%   81.84%   +0.13%     
===========================================
  Files           16       16              
  Lines         2132     2137       +5     
  Branches       346      346              
===========================================
+ Hits          1742     1749       +7     
+ Misses         255      254       -1     
+ Partials       135      134       -1     
Flag Coverage Δ
functional-tests 52.78% <22.22%> (-0.22%) ⬇️
unit-tests 79.50% <77.77%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swarna04 swarna04 merged commit d0e3dc4 into staging Jan 26, 2024
6 checks passed
swarna04 added a commit that referenced this pull request Jan 26, 2024
* Target SDK should attach response tokens in the retrieveLocationContent data callback (#34)

* Target SDK should attach response tokens in the retrieveLocationContent data callback

* Bumped extension version

* minor fix, testapp and doc updates

* Added additional test

* Fixed failing test

* More test fixes

* Added additional tests to bump patch coverage (#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants