Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flickering in Activities of type redirect #1219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ninaceban
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the hide body was there in the first place and why it is no longer needed?

@carterworks
Copy link
Contributor

carterworks commented Nov 18, 2024

Can you explain why the hide body was there in the first place and why it is no longer needed?

@jonsnyder It's the opposite—hideElements("BODY") was not there in the first place.

@ninaceban
Copy link
Contributor Author

Can you explain why the hide body was there in the first place and why it is no longer needed?

@jonsnyder It's the opposite—hideElements("BODY") was not there in the first place.

Earlier in Personalization component when a redirect type of item was returned from the Edge, it was turning Web SDK into a different mode than what it was running for rest of propositions type.

After the refactoring was done, the processing and rendering is happening in an async mode while showContainers is called in a sync mode.
What happens now is that processing/rendering of the propositions happens async and till redirect executes, showContainers which is called sync already kicks in and unhides the body. By hiding Body in case redirect item is executed we can avoid flickering. This is the only quick fix that would fix flickering and not touch current refactoring of the Personalization component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants