Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Poor keyboard interaction in last stage of Replace dialog #5005

Closed
peterflynn opened this issue Aug 30, 2013 · 4 comments
Closed

Poor keyboard interaction in last stage of Replace dialog #5005

peterflynn opened this issue Aug 30, 2013 · 4 comments

Comments

@peterflynn
Copy link
Member

  1. Invoke Replace, type some search text, press Enter
  2. Type some replacement text, press Enter
  3. Try to skip or cancel the Replace operation via keyboard

Result: Escape, Y, N, A, S all do nothing.
You can press Enter and Tab/Shift-Tab to "click" the focused button, but that's it.

Expected: Escape closes the Find/Replace bar in all other cases, so it should close here too. Keyboard shortcuts for the other buttons would be nice too though.

@redmunds
Copy link
Contributor

There's a backlog item for this: https://trello.com/c/7HVPLeer/975-replace-dialog-keyboard-support

@mrplants
Copy link

I'm a brand new contributor and would like to take this on as a first foray into open-source.

@mrplants
Copy link

I fixed the bug and submitted a Pull Request as it states in the above post.

@ghost ghost assigned peterflynn Dec 3, 2013
@peterflynn
Copy link
Member Author

Closing since this has been superseded by #6175

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants