Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Poor keyboard interaction in last stage of Replace dialog #4611

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Friday Aug 30, 2013 at 05:25 GMT
Originally opened as adobe/brackets#5005


  1. Invoke Replace, type some search text, press Enter
  2. Type some replacement text, press Enter
  3. Try to skip or cancel the Replace operation via keyboard

Result: Escape, Y, N, A, S all do nothing.
You can press Enter and Tab/Shift-Tab to "click" the focused button, but that's it.

Expected: Escape closes the Find/Replace bar in all other cases, so it should close here too. Keyboard shortcuts for the other buttons would be nice too though.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday Aug 30, 2013 at 15:51 GMT


There's a backlog item for this: https://trello.com/c/7HVPLeer/975-replace-dialog-keyboard-support

@core-ai-bot
Copy link
Member Author

Comment by mrplants
Tuesday Nov 12, 2013 at 22:40 GMT


I'm a brand new contributor and would like to take this on as a first foray into open-source.

@core-ai-bot
Copy link
Member Author

Comment by mrplants
Tuesday Nov 12, 2013 at 23:36 GMT


I fixed the bug and submitted a Pull Request as it states in the above post.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Dec 09, 2013 at 19:02 GMT


Closing since this has been superseded by #6175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant