This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Use a more reliable way to determine whether focus is in an inline widget #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
BTW, note that |
|
Looks good. Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Dec 20, 2012
Use a more reliable way to determine whether focus is in an inline widget
|
That's very strange -- looking at the jQuery code, it just does |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for inline widgets fail intermittently when run as part of the entire test suite. The problem appears to be that the way we're determining whether a widget currently has focus isn't entirely reliable for some reason. This pull request uses a different method that seems like it ought to be reasonably foolproof.