Resize QuickOpen results if the window size is changed, and add scroll bars #6325
Conversation
|
my first commit cause the search results to expand to full window size even when there were fewer results. this corrects it |
…query was changed after resizing brackets window
|
@ishanatmuz The core team is on break until New Year's, so just fyi it will be a few more days before anyone is able to take a look at this in detail. |
|
|
||
| // Listen for the resizing of window to resize and move the smart_autocomplete_container accordingly | ||
| $(window).resize(function () { | ||
| var _smartAutocompleteContainerHeight = parseInt($(".main-view").css("height"), 10) - parseInt($("#status-bar").css("height"), 10) - 10; |
There was a problem hiding this comment.
Would be better to avoid this code duplication
|
I am new to git. I never intended the commit 59671c3 to get included into this branch. |
ghost
assigned 
|
@ishanatmuz That's fine - it's just showing that you merged our master into your branch. It won't have any effect if/when we merge your branch back into master. |
|
Bugs:
|
|
@SAplayer I am not that acquainted with bracket's source, though I will try to find how to fix this. If you have any ideas on what might be causing it and/or the direction where to look, please post here. That would be invaluable. |
|
The problem with closing is maybe the auto-close of the ModalBars, which closes every ModalBar as soon as you click into the editor. A dev can tell you more about these for sure. |
|
@peterflynn is this something you'd still like to dig into - maybe @redmunds could help? |
|
@ishanatmuz The PR I mentioned is now posted as #7227 -- sorry for the delay in getting that cleaned up & ready. My new code still uses left/top, so the snippet I mentioned above doesn't go away entirely -- but I think if you base a patch on top of the branch in #7227 it will be a good deal cleaner. You can put the resize handler directly in QuickSearchField, instead of having to poke at it from outside. And you can just change left/top directly now, instead of having to calculate a delta & set margin to adjust the position. |
|
@peterflynn I have my University exams going on right now. They will be over by 23rd of May. If you can wait till then, then I would appreciate it. |
|
It sounds like this PR should be re-worked on top of #7227 (branch @ishanatmuz, do you have time to submit a new PR as @peterflynn suggests? |
|
@ishanatmuz are you willing to setup a new PR with this fix? |
|
@ficristo I was caught up with other things in my life that I completely forgot about this. Let me see what I can do. |
These changes add a scroll-bar to the results of QuickOpen when there are more results that can fit in the screen.
It also moves the results horizontally with the QuickOpen input area.
This addresses issues #1156 and #1157
Result :
