-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store version on delete in all cases #86
Conversation
Note that I need to work on the tests. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 52.89% 53.64% +0.75%
==========================================
Files 38 38
Lines 1779 1795 +16
==========================================
+ Hits 941 963 +22
+ Misses 838 832 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @auniverseaway, wdyt?
Looks good to me. It would be nice to get some performance numbers... if you delete 1000 pages, you will be creating 1000 versions. |
Fixes: #85
Types of changes
Checklist: