Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store version on delete in all cases #86

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Store version on delete in all cases #86

merged 4 commits into from
Oct 17, 2024

Conversation

bosschaert
Copy link
Contributor

Fixes: #85

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bosschaert bosschaert requested a review from karlpauls October 11, 2024 14:35
@bosschaert bosschaert changed the title Store on delete in all cases Store version on delete in all cases Oct 11, 2024
@bosschaert
Copy link
Contributor Author

Note that I need to work on the tests.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.64%. Comparing base (e4b15cf) to head (aed0471).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/version/put.js 83.33% 2 Missing ⚠️
src/storage/object/delete.js 96.15% 1 Missing ⚠️
src/storage/object/move.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   52.89%   53.64%   +0.75%     
==========================================
  Files          38       38              
  Lines        1779     1795      +16     
==========================================
+ Hits          941      963      +22     
+ Misses        838      832       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@karlpauls karlpauls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @auniverseaway, wdyt?

@bosschaert bosschaert marked this pull request as ready for review October 16, 2024 14:44
@auniverseaway
Copy link
Member

Looks good to me. It would be nice to get some performance numbers... if you delete 1000 pages, you will be creating 1000 versions.

@bosschaert bosschaert merged commit e407d91 into main Oct 17, 2024
5 checks passed
@bosschaert bosschaert deleted the store-on-delete branch October 17, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure a version with content is stored on delete
3 participants