Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlx package has problems with some es6 dependencies #1228

Closed
tripodsan opened this issue Nov 15, 2019 · 1 comment · Fixed by #1229
Closed

hlx package has problems with some es6 dependencies #1228

tripodsan opened this issue Nov 15, 2019 · 1 comment · Fixed by #1229
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

Description
having a dependency with provides a common and a es6 version causes problems with webpack when creating the action bundle.

for example: MikeMcl/big.js#95

Solution

The solution is to change the module resolution order in webpack.
@tripodsan tripodsan added the bug Something isn't working label Nov 15, 2019
@tripodsan tripodsan self-assigned this Nov 15, 2019
tripodsan added a commit that referenced this issue Nov 15, 2019
@tripodsan
fix(package): ensure correct module resolution order
9a3aa70 
fixes #1228
@tripodsan tripodsan mentioned this issue Nov 15, 2019
Merged
tripodsan added a commit that referenced this issue Nov 15, 2019
@tripodsan
fix(package): ensure correct module resolution order (#1229)
ad59326 
fixes #1228
trieloff pushed a commit that referenced this issue Nov 15, 2019
@semantic-release-bot
chore(release): 6.0.3 [skip ci]
2bf34a6 
## [6.0.3](v6.0.2...v6.0.3) (2019-11-15)

### Bug Fixes

* **package:** ensure correct module resolution order ([#1229](#1229)) ([ad59326](ad59326)), closes [#1228](#1228)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(package): ensure correct module resolution order adobe/helix-cli
2 participants
@tripodsan @adobe-bot