Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: deploy doesn't work with many dependencies #12

Closed
tripodsan opened this issue Dec 13, 2020 · 3 comments
Closed

AWS: deploy doesn't work with many dependencies #12

tripodsan opened this issue Dec 13, 2020 · 3 comments
Assignees
Labels

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Dec 13, 2020

1 validation error detected: Value '{[email protected]@[email protected]@238041cbe3f89b7b5efed9d7e4aedf37a2653f907d, repository=https@3A@[email protected]@[email protected], updated=1607869330560, pkgVersion=1.7.17_hedy, dependencies=@adobe/gh-resolve-ref:1.1.0,@adobe/helix-fetch:1.9.2,@adobe/helix-log:4.5.3,@adobe/helix-status:8.2.3,@adobe/openwhisk-action-utils:4.4.0,already:1.13.2,asynckit:0.4.0,balanced-match:1.0.0,big.js:6.0.2,brace-expansion:1.1.11,buffer-from:1.1.1,bunyan:1.8.14,callguard:2.0.0,centra:2.4.0,colorette:1.1.0,combined-stream:1.0.8,concat-map:0.0.1,core-util-is:1.0.2,delayed-stream:1.0.0,dtrace-provider:0.8.8,ferrum:1.7.0,fetch-h2:2.5.1,form-data:3.0.0,get-stream:6.0.0,glob:6.0.4,http-cache-semantics:4.1.0,inflight:1.0.6,inherits:2.0.4,isarray:1.0.0,lodash.isplainobject:4.0.6,lru-cache:6.0.0,mime-db:1.43.0,mime-types:2.1.26,minimatch:3.0.4,mkdirp:0.5.5,mv:2.1.1,ncp:2.0.0,node-fetch:2.6.1,object-sizeof:1.6.1,once:1.4.0,path-is-absolute:1.0.1,phin:3.4.1,process-nextick-args:2.0.1,psl:1.8.0,readable-stream:3.6.0,readable-stream:2.3.7,rimraf:2.4.5,safe-buffer:5.1.2,safe-json-stringify:1.2.0,serverless-http:2.6.0,source-map:0.6.1,source-map-support:0.5.19,string_decoder:1.1.1,throat:5.0.0,through2:4.0.2,to-arraybuffer:1.0.1,tough-cookie:4.0.0,triple-beam:1.3.0,universalify:0.1.2,util-deprecate:1.0.2,webpack:4.41.2,winston-transport:4.3.0,wrappy:1.0.2,yallist:4.0.0}' 
at 'tags' failed to satisfy constraint: Map value must satisfy constraint: [Member must have length less than or equal to 256, Member must have length greater than or equal to 0, Member must satisfy regular expression pattern: ^([\p{L}\p{Z}\p{N}_.:/=+\-@]*)$]
@trieloff
Copy link
Contributor

256 chars don't give us too much wiggle room. We could create one tag for each dependency or just truncate the value.

@tripodsan
Copy link
Contributor Author

for now I would ignore the dependency information or put it inside a dependency.json in the zip.
we can later figure out how to retrieve it efficiently.

in any case with I/O runtime we already have a comprehensive database of all the actions and dependencies.
so, if we need to figure out which action/version contains a certain dependency, we can retrieve it there.

@tripodsan tripodsan self-assigned this Dec 14, 2020
@tripodsan tripodsan mentioned this issue Dec 14, 2020
github-actions bot pushed a commit that referenced this issue Dec 15, 2020
# [1.5.0](v1.4.0...v1.5.0) (2020-12-15)

### Bug Fixes

* **aws:** add route for requests with suffix ([a3240ac](a3240ac)), closes [#13](#13)
* **aws:** dependency list not valid tag value ([03172a2](03172a2)), closes [#12](#12)
* **deploy:** allow each deployer to specify test ([b004fe4](b004fe4)), closes [#10](#10)

### Features

* **adapter:** include suffix / __ow_path in context ([21e4e2c](21e4e2c)), closes [#17](#17)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants