Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws): ensure version in context.func is correct #138

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fix(aws): ensure version in context.func is correct #138

merged 1 commit into from
Mar 3, 2021

Conversation

tripodsan
Copy link
Contributor

fixes #129

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This PR will trigger a patch release when merged.

@tripodsan tripodsan requested a review from trieloff March 2, 2021 09:00
@codecov
Copy link

codecov bot commented Mar 2, 2021 •
edited
Loading

Codecov Report

Merging #138 (2fd37c9) into main (f4214ee) will decrease coverage by 1.10%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   82.86%   81.76%   -1.11%     
==========================================
  Files          18       19       +1     
  Lines        1138     1157      +19     
==========================================
+ Hits          943      946       +3     
- Misses        195      211      +16
Impacted Files Coverage Δ
src/template/aws-package-params.js 10.52% <10.52%> (ø)
src/deploy/AWSDeployer.js 74.87% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab250f...2fd37c9. Read the comment docs.

@tripodsan tripodsan merged commit 97b9a39 into main Mar 3, 2021
@tripodsan tripodsan deleted the fix-aws-version branch March 3, 2021 01:35
github-actions bot pushed a commit that referenced this pull request Mar 3, 2021
@semantic-release-bot
chore(release): 3.6.1 [skip ci]
6e7c5fb 
## [3.6.1](v3.6.0...v3.6.1) (2021-03-03)

### Bug Fixes

* **aws:** ensure version in context.func is correct ([#138](#138)) ([97b9a39](97b9a39)), closes [#129](#129)
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trieloff trieloff trieloff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS: Is the Version Number wrong?
2 participants
@tripodsan @trieloff