Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idField #465

Merged
merged 2 commits into from
Nov 21, 2024
Merged

idField #465

merged 2 commits into from
Nov 21, 2024

Conversation

marshallpete
Copy link
Member

Description

Add an idField prop. This allows the consumer to specify a field in the data set that contains a unique ID for each data point.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions GitHub Actions
Copy link

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-465

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-465

@Bryant-Curtis Bryant-Curtis merged commit 533d81d into main Nov 21, 2024
5 checks passed
@Bryant-Curtis Bryant-Curtis deleted the idField branch November 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryant-Curtis Bryant-Curtis Bryant-Curtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marshallpete @Bryant-Curtis