-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden DisclosurePanel
s are given display: none
by tailwind's base layer
#7160
Comments
neefrehman
changed the title
DisclosurePanels are given
Hidden Oct 8, 2024
display: none
when hidden by tailwindDisclosurePanel
s are given display: none
by tailwind's base layer
adamwathan
added a commit
to tailwindlabs/tailwindcss
that referenced
this issue
Oct 8, 2024
Fixes an issue reported by the React Aria Components team here: adobe/react-spectrum#7160 Basically `hidden="until-found"` behaves very differently than `hidden` and doesn't actually use `display: none`, so we don't want to apply the behavior we apply for the regular `hidden` attribute.
Thanks for reporting! I reached out to the Tailwind team about this and they are looking into updating their reset. See tailwindlabs/tailwindcss#14625 |
RobinMalfait
added a commit
to tailwindlabs/tailwindcss
that referenced
this issue
Oct 9, 2024
Fixes an issue reported by the React Aria Components team here: adobe/react-spectrum#7160 Basically `hidden="until-found"` behaves very differently than `hidden` and doesn't actually use `display: none`, so we don't want to apply the behavior we apply for the regular `hidden` attribute.
RobinMalfait
added a commit
to tailwindlabs/tailwindcss
that referenced
this issue
Oct 9, 2024
…#14625) Fixes an issue reported by the React Aria Components team here: adobe/react-spectrum#7160 Basically `hidden="until-found"` behaves very differently than `hidden` and doesn't actually use `display: none`, so we don't want to apply the behavior we apply for the regular `hidden` attribute. --------- Co-authored-by: Robin Malfait <[email protected]>
RobinMalfait
added a commit
to tailwindlabs/tailwindcss
that referenced
this issue
Oct 9, 2024
…#14631) Fixes an issue reported by the React Aria Components team here: adobe/react-spectrum#7160 Basically `hidden="until-found"` behaves very differently than `hidden` and doesn't actually use `display: none`, so we don't want to apply the behavior we apply for the regular `hidden` attribute.
This should be fixed and will be available in the next release of Tailwind CSS. Will leave a comment when we have a new version out. |
RobinMalfait
added a commit
to tailwindlabs/tailwindcss
that referenced
this issue
Oct 9, 2024
…#14631) Fixes an issue reported by the React Aria Components team here: adobe/react-spectrum#7160 Basically `hidden="until-found"` behaves very differently than `hidden` and doesn't actually use `display: none`, so we don't want to apply the behavior we apply for the regular `hidden` attribute.
Hi! Quick update, this has been released in the latest v3 version and the latest v4 alpha release.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Provide a general summary of the issue here
I'm currently implementing
Disclosure
in a codebase that uses tailwind. At first, when nesting aTable
element inside this disclosure, I noticed some jank related to column widths. After some investigation I found that theDisclosurePanel
element implicitly had a width of0
, due to having been givendisplay: none
by tailwind's@tailwind base
layer:Tailwind source can be seen here, (and on the
next
branch it will be made!important
)To bring the behaviour closer in line with how
details
/summary
elements work, I've had to override this manually:But, since I'm also using the
tailwindcss-react-aria-components
plugin, I wonder if this is something that could be handled there?🤔 Expected Behavior?
DisclosurePanel
elements should inherit their parent's width, even when hidden, as implementations in the docs do.😯 Current Behavior
DisclosurePanel
elements have no width due to tailwind's reset, leading to potentially janky animations when opening them💁 Possible Solution
The
tailwindcss-react-aria-components
plugin could help undo this forDisclosurePanel
elements.🔦 Context
No response
🖥️ Steps to Reproduce
Use
Disclosure
in any codebase that adds tailwind's@tailwind base
stylesVersion
"react-aria-components": "1.4.0"
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response
The text was updated successfully, but these errors were encountered: