Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Textarea/Textfield padding and alignment #162

Closed
wants to merge 3 commits into from

Conversation

lazd
Copy link
Member

@lazd lazd commented Jan 21, 2020

This PR includes the changes made to Spectrum CSS as part of adobe/spectrum-css#490

I am sending this because @LFDanLu originally reported this issue against Spectrum CSS, but it required some code changes to test in V3 and they were simple enough to bang out real quick.

Closes adobe/spectrum-css#454

✅ Pull Request Checklist:

📝 Test Instructions:

Load up http://localhost:9003/?path=/story/textarea--icon-info, it should look like this:
image

It should not look like this:
image

🧢 Your Team:

Spectrum

@adobe-bot
Copy link

Build successful! View the storybook

@adobe-bot
Copy link

Build successful! View the storybook

@LFDanLu
Copy link
Member

LFDanLu commented Jan 22, 2020

@lazd For the most part these changes look good, but I did notice a small sizing quirk for Quiet TextAreas. If you go to https://reactspectrum.blob.core.windows.net/reactspectrum/8fde1942847c88c3ee4fe8007ad9f8055b27bdd6/index.html?path=/story/textarea--isquiet-true, and begin typing into the quiet textarea, you'll notice that that the textarea's height immediately adjusts itself by 2px, something that doesn't happen with the old version of textarea. I can't quite pinpoint why this is happening since changing the --spectrum-textfield-padding-top from 3px to 5px in the old version of the css works just fine.

Before:
image
After:
image

@lazd lazd mentioned this pull request Feb 12, 2020
5 tasks
@dannify dannify changed the base branch from master to main July 12, 2020 00:54
@adobe-bot
Copy link

Build successful! 🎉

@dannify
Copy link
Member

dannify commented Oct 15, 2021

Cleaning up. This will be picked up in a future audit of Textfield.

@dannify dannify closed this Oct 15, 2021
@snowystinger snowystinger deleted the textarea-padding branch December 6, 2021 23:56
devongovett pushed a commit that referenced this pull request Jul 25, 2024
* initial ContextualHelp implementation

* Adding ContextualHelp to FieldLabel

* fix crash in textfield contextual help story

* Updating ContextualHelp positioning in FieldLabel

* field label and contextual help button sizes match

* adding contextualhelp to monopackage for release

* storybook autodocs working

* Improving ContextualHelp positioning

* adding combobox contextualhelp story

* Improving popover focus

* Improving popover focus

* Improving contextual help placement in field and aria labeling

* updating links to have hrefs

* Fixing button context and popover style

* updated useId and aria-label in field label

---------

Co-authored-by: Kyle Taborski <[email protected]>
Co-authored-by: danilu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(TextArea) Text is 1px too high
5 participants