-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct Textarea/Textfield padding and alignment #162
Conversation
Build successful! View the storybook |
Build successful! View the storybook |
@lazd For the most part these changes look good, but I did notice a small sizing quirk for Quiet TextAreas. If you go to https://reactspectrum.blob.core.windows.net/reactspectrum/8fde1942847c88c3ee4fe8007ad9f8055b27bdd6/index.html?path=/story/textarea--isquiet-true, and begin typing into the quiet textarea, you'll notice that that the textarea's height immediately adjusts itself by 2px, something that doesn't happen with the old version of textarea. I can't quite pinpoint why this is happening since changing the |
Build successful! 🎉 |
Cleaning up. This will be picked up in a future audit of Textfield. |
* initial ContextualHelp implementation * Adding ContextualHelp to FieldLabel * fix crash in textfield contextual help story * Updating ContextualHelp positioning in FieldLabel * field label and contextual help button sizes match * adding contextualhelp to monopackage for release * storybook autodocs working * Improving ContextualHelp positioning * adding combobox contextualhelp story * Improving popover focus * Improving popover focus * Improving contextual help placement in field and aria labeling * updating links to have hrefs * Fixing button context and popover style * updated useId and aria-label in field label --------- Co-authored-by: Kyle Taborski <[email protected]> Co-authored-by: danilu <[email protected]>
This PR includes the changes made to Spectrum CSS as part of adobe/spectrum-css#490
I am sending this because @LFDanLu originally reported this issue against Spectrum CSS, but it required some code changes to test in V3 and they were simple enough to bang out real quick.
Closes adobe/spectrum-css#454
✅ Pull Request Checklist:
📝 Test Instructions:
Load up http://localhost:9003/?path=/story/textarea--icon-info, it should look like this:
![image](https://user-images.githubusercontent.com/201344/72852823-9a385280-3c64-11ea-909e-069b01538bf1.png)
It should not look like this:
![image](https://user-images.githubusercontent.com/201344/72852828-9e647000-3c64-11ea-83a2-75751aabebf2.png)
🧢 Your Team:
Spectrum