Font improvements, loading fonts in Storybook, and adding more font Chromatic stories #4238
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Copyright 2020 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
| import {ComponentMeta, ComponentStoryObj} from '@storybook/react'; | ||
| import {Content} from '@react-spectrum/view'; | ||
| import {Flex} from '@react-spectrum/layout'; | ||
| import {Heading} from '@react-spectrum/text'; | ||
| import {IllustratedMessage} from '..'; | ||
| import NotFound from '@spectrum-icons/illustrations/src/NotFound'; | ||
| import React from 'react'; | ||
|
|
||
| type IllustratedMessageStory = ComponentStoryObj<typeof IllustratedMessage>; | ||
|
|
||
| export default { | ||
| title: 'Languages/IllustratedMessage', | ||
| component: IllustratedMessage, | ||
| parameters: { | ||
| chromaticProvider: { | ||
| colorSchemes: ['light'], | ||
| locales: ['en-US', 'ar-AE', 'zh-CN', 'zh-TW', 'ja-JP', 'ko-KR'], | ||
| scales: ['large'], | ||
snowystinger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| express: false | ||
| } | ||
| } | ||
| } as ComponentMeta<typeof IllustratedMessage>; | ||
|
|
||
| export const _NotFound: IllustratedMessageStory = { | ||
| render: () => ( | ||
| <Flex gap="size-200" direction="row" wrap> | ||
| <IllustratedMessage width="size-2000"> | ||
| <NotFound /> | ||
| <Heading>Error 404</Heading> | ||
| <Content>Page not found</Content> | ||
| </IllustratedMessage> | ||
| <IllustratedMessage width="size-2000"> | ||
| <NotFound /> | ||
| <Heading>404 خطأ</Heading> | ||
| <Content>الصفحة غير موجودة</Content> | ||
| </IllustratedMessage> | ||
| <IllustratedMessage width="size-2000"> | ||
| <NotFound /> | ||
| <Heading>错误 404</Heading> | ||
| <Content>找不到网页</Content> | ||
| </IllustratedMessage> | ||
| <IllustratedMessage width="size-2000"> | ||
| <NotFound /> | ||
| <Heading>錯誤 404</Heading> | ||
| <Content>找不到網頁</Content> | ||
| </IllustratedMessage> | ||
| <IllustratedMessage width="size-2000"> | ||
| <NotFound /> | ||
| <Heading>エラー 404</Heading> | ||
| <Content>ページが見つかりません</Content> | ||
| </IllustratedMessage> | ||
| <IllustratedMessage width="size-2000"> | ||
| <NotFound /> | ||
| <Heading>오류 404</Heading> | ||
| <Content>페이지를 찾을 수 없음</Content> | ||
| </IllustratedMessage> | ||
| </Flex> | ||
| ), | ||
| name: 'Not found: no italic in CCJK' | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ import {storiesOf} from '@storybook/react'; | |
| import {TextField} from '../'; | ||
|
|
||
| storiesOf('Textfield', module) | ||
| .addParameters({chromaticProvider: {locales: ['en-US', 'ar-AE']}}) | ||
| .add( | ||
| 'Default', | ||
| () => render() | ||
|
|
@@ -82,14 +82,6 @@ storiesOf('Textfield', module) | |
| .add('custom width', | ||
| () => render({icon: <Info />, validationState: 'invalid', width: 275}) | ||
| ) | ||
| .add( | ||
| 'contextual help', | ||
| args => render({...args, contextualHelp: ( | ||
|
|
@@ -118,6 +110,35 @@ storiesOf('Textfield', module) | |
| )}, false) | ||
| ); | ||
|
|
||
| storiesOf('Languages/Textfield', module) | ||
|
There was a problem hiding this comment. Adding this story to confirm the state of #3983 with the correct fonts, which is currently a failure. |
||
| .addParameters({ | ||
| chromaticProvider: { | ||
| colorSchemes: ['light'], | ||
| express: false, | ||
| locales: ['en-US', 'ar-AE', 'fr-FR', 'de-DE', 'zh-TW'], | ||
| scales: ['large'] | ||
| } | ||
| }) | ||
| .add( | ||
| 'diacritics', | ||
| () => ( | ||
| <Flex gap="size-200" direction="row" wrap> | ||
| <TextField label="Label" value="value" /> | ||
| <TextField label="رِفِتـــانٍ خانٍِ" value="رِفِتـــانٍ خانٍِ" /> | ||
| <TextField label="Ç" value="Ç" /> | ||
| <TextField label="Äpfel" value="Äpfel" /> | ||
| </Flex> | ||
| ) | ||
| ) | ||
| .add( | ||
| 'value: 測試, icon: Info, labelPosition: side, validationState: valid', | ||
| () => render({value: '測試', icon: <Info />, labelPosition: 'side', validationState: 'valid'}) | ||
| ) | ||
| .add( | ||
| 'value: اختبار, isRequired: false, necessityIndicator: label', | ||
| () => render({value: 'اختبار', isRequired: false, necessityIndicator: 'label'}) | ||
| ); | ||
|
|
||
| // allow some stories where disabled styles probably won't affect anything to turn that off, mostly to reduce clutter | ||
| function render(props = {}, disabled = true) { | ||
| return ( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing all Chromatic font stories are in a "Languages" package, so we can more easily adjust locales without impacting other stories and they aren't spread all over the place.