Fix diacritics in textfields #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
yihuiliao
reviewed
May 25, 2023
reidbarber
previously approved these changes
May 25, 2023
yeah, i'm running it on main right now, then I'll run it here |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
commented
Jun 1, 2023
packages/@adobe/spectrum-css-temp/components/textfield/index.css
Outdated
Show resolved
Hide resolved
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Jun 2, 2023
LFDanLu
approved these changes
Jun 2, 2023
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3983
✅ Pull Request Checklist:
📝 Test Instructions:
Go to new story, change the locale, a different string will appear for each one. The big difference is if you toggle Zalgo text, here you can see the full range of area in which we can display a diacritic has been increased. It's gibberish, just shows where the cut off is. If you pull this locally, you can ever the change and compare to where it used to be cut off.
Note, this is safe, we'll never extend out beyond the bounds of the textfield itself, the text is overflow hidden if it tries to. With the exception of Zalgo and maybe some Tibet strings which Spectrum doesn't support anyways, the diacritics should never extend this far in the vertical range.
🧢 Your Project: