Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Submenu translations in NextJS app #5601

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Fix Submenu translations in NextJS app #5601

merged 6 commits into from
Dec 19, 2023

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Dec 19, 2023

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu LFDanLu changed the title Tentative fix for nextJS test app (WIP) Tentative fix for nextJS test app Dec 19, 2023
@LFDanLu
Copy link
Member Author

LFDanLu commented Dec 19, 2023

One sec, this doesn't seem to actually fix it locally

@rspbot
Copy link

rspbot commented Dec 19, 2023

@LFDanLu LFDanLu changed the title (WIP) Tentative fix for nextJS test app Fix Submenu translations in NextJS app Dec 19, 2023
@rspbot
Copy link

rspbot commented Dec 19, 2023

@rspbot
Copy link

rspbot commented Dec 19, 2023

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@LFDanLu LFDanLu merged commit 125d65c into main Dec 19, 2023
26 checks passed
@LFDanLu LFDanLu deleted the fix_next_app branch December 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants