Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using byContentVal decorator #3

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

cuberoot
Copy link
Contributor

I was getting an error about writing to a read-only property when I used @byContentVal

Description

I found that the decorators that worked for me marked the property as writable. I fixed byContentVal to do the same.

Related Issue

Motivation and Context

How Has This Been Tested?

I ran the included unit tests

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

I was getting an error about writing to a read-only property when I used `@byContentVal`
Add a test that modifies the content of a child that is watched using `@byContentVal` to make sure that the model updates
@alexmirea alexmirea merged commit 8a8637c into adobe:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants