Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pickerbutton)!: migrate tokens #1940

Merged
merged 26 commits into from
Jul 31, 2023
Merged

feat(pickerbutton)!: migrate tokens #1940

merged 26 commits into from
Jul 31, 2023

Conversation

mlogsdon18
Copy link
Contributor

@mlogsdon18 mlogsdon18 commented Jun 15, 2023 •
edited
Loading

Description

This PR updates the Picker Button component to use the new tokens. It is based on the In-field Button PR so that one will need to go in first, as it uses a lot of the same tokens.

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • In-field tokens have been added to the main tokens release
  • This pull request is ready to merge.

@mlogsdon18 mlogsdon18 added the do not merge A flag for a branch indicating it should not be merged. label Jun 15, 2023
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from b7c362a to a32497d Compare June 16, 2023 15:06
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023 •
edited
Loading

🚀 Deployed on https://pr-1940--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 16, 2023 15:13 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from 50d0f97 to a717001 Compare June 16, 2023 15:22
@github-actions github-actions bot temporarily deployed to pull request June 16, 2023 15:28 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from a717001 to 5c4b61e Compare June 20, 2023 13:28
@github-actions github-actions bot temporarily deployed to pull request June 20, 2023 13:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 20, 2023 18:04 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch 3 times, most recently from 910282c to e909107 Compare June 21, 2023 18:58
@github-actions github-actions bot temporarily deployed to pull request June 21, 2023 19:04 Inactive
jenndiaz
jenndiaz suggested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jenndiaz jenndiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, just a couple of questions/comments

@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from e909107 to 8b2bb31 Compare June 23, 2023 13:42
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 13:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2023 14:28 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from 93179d1 to 0493a75 Compare June 26, 2023 15:50
@github-actions github-actions bot temporarily deployed to pull request June 26, 2023 15:57 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from 0493a75 to 349fd66 Compare June 26, 2023 16:49
@github-actions github-actions bot temporarily deployed to pull request June 26, 2023 16:55 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch 2 times, most recently from f68240d to 137ca0d Compare June 27, 2023 14:14
@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 14:23 Inactive
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch 4 times, most recently from a3a2fb2 to fa900d1 Compare July 3, 2023 19:54
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch 2 times, most recently from ce83505 to 2fdd6e9 Compare July 11, 2023 14:57
mlogsdon18 and others added 24 commits July 31, 2023 13:40
@mlogsdon18
chore(pickerbutton): move css from generated to index
67317c2
@mlogsdon18
feat(pickerbutton): updating with tokens
5381d22
@mlogsdon18
docs(pickerbutton): update docs html to correct icon sizes
349337b
@mlogsdon18
refactor(pickerbutton): fixing variable names and tokens
1c70355
@mlogsdon18
chore(pickerbutton): update story
26ae757
@mlogsdon18
chore(pickerbutton): update storybook controls and template
8cb0c51
@mlogsdon18
chore(pickerbutton): adding more storybook stories for express, quiet…
16314e5 
… etc
@mlogsdon18
fix(pickerbutton): fixing icon color
00548ba
@mlogsdon18
chore(pickerbutton): reset yarn file
ddb07ab
@mlogsdon18
chore: reset yarn file
4cc5b4a
@mlogsdon18
refactor(pickerbutton): fix button fill padding calculations
83d6da1
@mlogsdon18
chore(pickerbutton): remove invalid and isKeyboardFocused variants
18aa954
@mlogsdon18
chore(pickerbutton): prevent focused and open when disabled
b649dd7
@mlogsdon18
fix(pickerbutton): fix disabled hover
ddd9bb9 
update mods
@mlogsdon18
fix(searchwithin): pass through mod for picker button border color
a8e3332
@mlogsdon18
chore(pickerbutton): bumping up tokens release
f69b1ec
@mlogsdon18
chore(pickerbutton): update token peer dependency
48ca59b
@mlogsdon18
fix(searchwithin): update searchwithin story to match docs site
bc7ed50 
use picker instead of pickerbutton
remove extra border
@pfulton @mlogsdon18
chore(pickerbutton): manual version increase for beta release
1db6230
@mlogsdon18
chore(pickerbutton): remove pickerbutton-generated css
97aef68
@mlogsdon18
fix(pickerbutton): remove icononly class and remove padding from uiic…
4d551fd 
…ononly

removes padding from uiicononly class to allow for larger icons in slots
@mlogsdon18
fix(pickerbutton): explicitly add box-sizing border-box
5d60a0d
@mlogsdon18
fix(pickerbutton): fix icon size
2b246ac
@pfulton @mlogsdon18
chore(pickerbutton): manual version increase for beta release
a680801
@mlogsdon18 mlogsdon18 force-pushed the picker-button-tokens branch from 29f306f to a680801 Compare July 31, 2023 17:40
@github-actions github-actions bot temporarily deployed to pull request July 31, 2023 17:48 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Jul 31, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Jul 31, 2023
@pfulton pfulton merged commit ad6051d into main Jul 31, 2023
@pfulton pfulton deleted the picker-button-tokens branch July 31, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenndiaz jenndiaz jenndiaz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlogsdon18 @pfulton @jenndiaz