feat(infieldbutton): migrate tokens #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlogsdon18
added
the
do not merge
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
5350d03 to
96f2e6a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
🚀 Deployed on https://pr-1912--spectrum-css.netlify.app |
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
2 times, most recently
from
1e0d085 to
87ebe40
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
2 times, most recently
from
b6a056c to
9bf6513
Compare
8 tasks
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
9bf6513 to
e1a5c08
Compare
jenndiaz
suggested changes
Jun 16, 2023
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
0c9912e to
55ec9b3
Compare
jenndiaz
reviewed
Jun 16, 2023
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
78de370 to
32738af
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
17704ca to
4ee01d6
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
4ee01d6 to
75e9c36
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
d480c64 to
7d39ec0
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
7d39ec0 to
e92841f
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
5fd8bf8 to
0ae0d61
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
0ae0d61 to
3443017
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
3443017 to
ef5c7a8
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
ef5c7a8 to
ad47672
Compare
pfulton
force-pushed
the
css-257-infield-button-tokens
branch
from
ad47672 to
081e6f2
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
081e6f2 to
53270cb
Compare
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
53270cb to
1aac573
Compare
pfulton
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Two things here @mlogsdon18:
- Can you add a Storybook story for the stacked variation?
- Can you double-check the
smallstacked variant on the docs site? It looks like the icons are not rendering properly.
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
51b8b56 to
4005bf2
Compare
pfulton
approved these changes
Jul 26, 2023
mlogsdon18
force-pushed
the
css-257-infield-button-tokens
branch
from
4005bf2 to
aca1df6
Compare
BREAKING CHANGE: updates infield button to use `@adobe/spectrum-tokens` docs(infieldbutton): remove small stacked variant from docs
pfulton
force-pushed
the
css-257-infield-button-tokens
branch
from
aca1df6 to
5198fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the In-Field Button component to use the new Spectrum tokens. This component currently is not being consumed by any other component and is not in Spectrum Web Components.
To-do list