Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spectrum-Well padding incorrect #422

Closed
NateBaldwinDesign opened this issue Dec 5, 2019 · 1 comment
Closed

spectrum-Well padding incorrect #422

NateBaldwinDesign opened this issue Dec 5, 2019 · 1 comment
Assignees
@lazd
Labels
bug Results from a bug in the CSS implementation

Comments

@NateBaldwinDesign
Copy link
Contributor

Description

Well should use var(--spectrum-global-dimension-size-200 for its padding in order to scale properly on mobile. This is current component with hardcoded 16px padding:
image

Steps to reproduce

  1. Go to http://opensource.adobe.com/spectrum-css/
  2. Click on ...
  3. Observe ...

Expected behavior

Screenshots

Environment

  • Spectrum CSS version:
  • Browser(s) and OS(s):

Additional context
@NateBaldwinDesign NateBaldwinDesign added the bug Results from a bug in the CSS implementation label Dec 5, 2019
@adobe-bot
Copy link

JIRA issue created: https://jira.corp.adobe.com/browse/SDS-4468

@NateBaldwinDesign NateBaldwinDesign changed the title Well padding incorrect spectrum-Well padding incorrect Dec 5, 2019
@lazd lazd self-assigned this Dec 5, 2019
lazd added a commit that referenced this issue Dec 10, 2019
@lazd
fix: implement local tokens for Well, fixes #422
491d52c
@lazd lazd closed this as completed in 81109f9 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazd lazd

Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lazd @NateBaldwinDesign @adobe-bot