Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large (quiet?) dropdowns do not look good #477

Closed
Harbs opened this issue Jan 14, 2020 · 3 comments · Fixed by #486
Closed

Large (quiet?) dropdowns do not look good #477

Harbs opened this issue Jan 14, 2020 · 3 comments · Fixed by #486
Assignees
Labels
bug Results from a bug in the CSS implementation

Comments

@Harbs
Copy link
Contributor

Harbs commented Jan 14, 2020

Description

Dropdowns don't behave very well at large sizes.

Steps to reproduce

  1. Go to https://unhurdle.github.io/spectrum-royale/
  2. Click on the "Medium" button
  3. Observe the button gets very wide

Expected behavior

  1. Go to http://opensource.adobe.com/spectrum-css/
  2. Click on the "Medium" button
  3. Observe the button is a normal size

Additional context

There is a class called "react-spectrum-Dropdown-flexible" which fixes the default spectrum behavior. While that's nice and all, it seems to me the fix should be in the core Spectrum CSS. 😉

@Harbs Harbs added the bug Results from a bug in the CSS implementation label Jan 14, 2020
@adobe-bot
Copy link

JIRA issue created: https://jira.corp.adobe.com/browse/SDS-4901

@lazd
Copy link
Member

lazd commented Jan 15, 2020

Yeah, React Spectrum specifically overrides that particular default behavior because it was considered backwards-incompatible to have a shifty quiet Dropdown, adding the flexible property to enable it. It's already implemented correctly in Spectrum CSS proper, so we can close this, but you're definitely right that it's looking wrong in the link!

@lazd lazd closed this as completed Jan 15, 2020
@lazd
Copy link
Member

lazd commented Jan 15, 2020

Wait, I see what you mean -- there is an override happening when using the multi-stop strategy that causes that dropdown to get way too wide. That's an easy fix, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants