Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added modal to tray component #776

Merged
merged 1 commit into from
Jul 29, 2020
Merged

fix: added modal to tray component #776

merged 1 commit into from
Jul 29, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Jul 29, 2020

Description

There are no tokens for tray bg so I brought in Modal to bring in the missing styles.

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for now. @GarthDB maybe we could have a not somewhere to keep track of this so we can switch out the DNA-token to the correct token when we get one.

@bernhard-adobe bernhard-adobe merged commit 74a02f0 into main Jul 29, 2020
@GarthDB GarthDB deleted the tray branch July 29, 2020 20:41
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants