Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added modal to tray component #776

Merged
merged 1 commit into from
Jul 29, 2020
Merged

fix: added modal to tray component #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/tray/metadata/tray.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ examples:
demoClassName: spectrum-CSSExample-example--overlay
markup: |
<div class="spectrum-Tray-wrapper spectrum-CSSExample-dialog">
<div class="spectrum-Tray is-open spectrum-Tray " style="max-height: calc(1149px - var(--spectrum-tray-margin-top));">
<div class="spectrum-Modal spectrum-Tray is-open spectrum-Tray " style="max-height: calc(1149px - var(--spectrum-tray-margin-top));">
<section class="spectrum-Dialog spectrum-Dialog--large" role="dialog" tabindex="-1" aria-modal="true">
<div class="spectrum-Dialog-grid">
<h1 class="spectrum-Dialog-heading spectrum-Dialog-heading--noHeader">New Messages</h1>
Expand Down
6 changes: 4 additions & 2 deletions components/tray/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,19 @@
"peerDependencies": {
"@spectrum-css/button": "^2.0.0",
"@spectrum-css/icon": "^2.0.0",
"@spectrum-css/vars": "^2.0.0"
"@spectrum-css/vars": "^2.0.0",
"@spectrum-css/modal": "^3.0.0-beta.0"
},
"devDependencies": {
"@spectrum-css/button": "^2.1.0",
"@spectrum-css/component-builder": "^1.1.0",
"@spectrum-css/icon": "^2.0.4",
"@spectrum-css/vars": "^2.1.0",
"@spectrum-css/modal": "^3.0.0-beta.0",
"gulp": "^4.0.0"
},
"publishConfig": {
"access": "public"
},
"homepage": "https://opensource.adobe.com/spectrum-css/"
}
}
3 changes: 0 additions & 3 deletions components/tray/skin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
.spectrum-Tray {
background-color: var(--spectrum-tray-background-color);
}