Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Button T-Shirt Sizes DNA v6.0.0-beta.18 #936

Closed
GarthDB opened this issue Sep 21, 2020 · 1 comment
Closed

Action Button T-Shirt Sizes DNA v6.0.0-beta.18 #936

GarthDB opened this issue Sep 21, 2020 · 1 comment
Assignees
@lazd
Labels
size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. sync to jira These will be pushed into adobe internal jira

Comments

@GarthDB
Copy link
Member

GarthDB commented Sep 21, 2020 •
edited by adobe-spectrum-bot
Loading

From DNA:

  • added dimension aliases for item-text-padding-top/bottom for all tshirt sizes
  • added dimension aliases for item-icon-padding-top/bottom for all tshirt sizes
  • added text and icon padding top & bottom to all tshirt sized primitives
  • restructured imports for action button to support t-shirt sizing. Restructuring adds -m to all existing variants.
  • added small, medium, large, and extra large variants of action button
  • updated quiet background and border colors
  • Added focus-ring-size, focus-ring-gap, and focus-ring-color to the selected-key-focus states of the Emphasized variations of ActionButton. This supports the design need for a "detached focus ring" for those variations in their selected state.

synced to jira: https://jira.corp.adobe.com/browse/SDS-7565
@GarthDB GarthDB mentioned this issue Sep 21, 2020
Closed
@GarthDB
Copy link
Member Author

GarthDB commented Sep 21, 2020

DNA v6.0.0-beta.24 adds missing focus-ring tokens to key-focus state of emphasized Action Button
Migration guide from DNA.
Part of DNA v6.0.0-beta.24.

@GarthDB GarthDB added the sync to jira These will be pushed into adobe internal jira label Sep 21, 2020
@GarthDB GarthDB changed the title Action Button T-Shirt Sizes Action Button T-Shirt Sizes DNA v6.0.0-beta.18 Sep 23, 2020
@GarthDB GarthDB added the size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. label Sep 25, 2020
@lazd lazd added size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. and removed size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. labels Sep 25, 2020
lazd added a commit that referenced this issue Sep 29, 2020
@lazd
feat: implement t-shirt sizing for Action Button, closes #936
b294eeb 
feat: break out ActionButton from Button

BREAKING CHANGE: .spectrum-ActionButton is no longer part of the button component, use the actionbutton component
lazd added a commit that referenced this issue Sep 29, 2020
@lazd
feat: implement t-shirt sizing for Action Button, closes #936
5c67e61 
feat: break out ActionButton from Button

BREAKING CHANGE: .spectrum-ActionButton is no longer part of the button component, use the actionbutton component
@lazd lazd mentioned this issue Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazd lazd

Labels
size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. sync to jira These will be pushed into adobe internal jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GarthDB @lazd