Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokens)!: prefer lowercase, hyphenated font names in font stacks #2007

Merged
merged 4 commits into from
Jul 13, 2023
Merged

feat(tokens)!: prefer lowercase, hyphenated font names in font stacks #2007

merged 4 commits into from
Jul 13, 2023

Conversation

pfulton
Copy link
Collaborator

@pfulton pfulton commented Jul 11, 2023

BREAKING CHANGE: updates the font-family stacks to remove the provided value from @adobe/spectrum-tokens, and instead use the "older" naming syntax that Spectrum CSS had used previously.

Slack discussion for context.

Description

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • This pull request is ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited
Loading

🚀 Deployed on https://pr-2007--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 11, 2023 19:16 Inactive
@pfulton pfulton requested a review from castastrophe July 11, 2023 20:32
@pfulton pfulton force-pushed the pfulton/font-stack-update branch from 9ca4111 to ef7ea1c Compare July 12, 2023 18:34
@github-actions github-actions bot temporarily deployed to pull request July 12, 2023 18:40 Inactive
pfulton added 2 commits July 13, 2023 10:47
@pfulton
feat(tokens)!: prefer lowercase, hyphenated font names in font stacks
61caa38 
BREAKING CHANGE: updates the font-family stacks to remove the provided
value from `@adobe/spectrum-tokens`, and instead use the "older" naming
syntax that Spectrum CSS had used previously.
@pfulton
refactor(tokens): retain older custom properties & reorder stacks
8bd7239
@pfulton pfulton force-pushed the pfulton/font-stack-update branch from ef7ea1c to 8bd7239 Compare July 13, 2023 14:47
@github-actions github-actions bot temporarily deployed to pull request July 13, 2023 15:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 13, 2023 15:26 Inactive
@pfulton pfulton merged commit e978a3a into main Jul 13, 2023
@pfulton pfulton deleted the pfulton/font-stack-update branch July 13, 2023 15:27
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfulton @castastrophe