-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add css minification output #2605
Conversation
🚀 Deployed on https://pr-2605--spectrum-css.netlify.app |
File metricsSummaryTotal size: 2.24 MB*
File change detailsaccordion
actionbar
actionbutton
actiongroup
alertbanner
alertdialog
asset
assetcard
assetlist
avatar
badge
breadcrumb
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
form
helptext
icon
illustratedmessage
infieldbutton
inlinealert
link
logicbutton
menu
meter
miller
modal
opacitycheckerboard
page
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
taggroup
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
2c63ab0
to
76c9fb0
Compare
76c9fb0
to
6050760
Compare
6050760
to
8748115
Compare
8ecac51
to
86f9349
Compare
683e326
to
ddea38a
Compare
🦋 Changeset detectedLatest commit: 69f4b06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
501f749
to
bf9ccf5
Compare
a3a4153
to
588578e
Compare
588578e
to
eb793c1
Compare
eb793c1
to
ec086af
Compare
ec086af
to
07d06c5
Compare
f282ddf
to
6d65fb4
Compare
131cacd
to
5a1f479
Compare
5a1f479
to
69f4b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. I was able to test locally by running yarn ci
and confirm the validation steps. 🎉
Of note: I tried to unzip the .gz
in MacOS via Finder and also with gunzip
via command line but it didn't understand the format. It seems this is because the headers use zlib format (file info is "zlib compressed data"). TIL. I think there's an option for gzip style headers or maybe the file could be named .zlib; I'm not sure if that's needed though.
Description
This PR would add a minified and gzipped output for all existing CSS exports. These assets are only created on production builds.
Jira CSS-880
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
To-do list