-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cssnano optimizations #2616
Conversation
File metricsSummaryTotal size: 4.48 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsaccordion
actionbar
actionbutton
actiongroup
alertbanner
alertdialog
asset
assetcard
assetlist
avatar
badge
breadcrumb
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
helptext
icon
illustratedmessage
infieldbutton
inlinealert
link
logicbutton
menu
miller
modal
opacitycheckerboard
page
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
site
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
taggroup
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
1362a5c
to
08149bc
Compare
🚀 Deployed on https://pr-2616--spectrum-css.netlify.app |
6b9efad
to
25605b0
Compare
faa8e66
to
a40ea23
Compare
🦋 Changeset detectedLatest commit: 329dc67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 82 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f1684ff
to
6aad672
Compare
1421c71
to
902501b
Compare
f4ca997
to
9531d78
Compare
eb91f7a
to
bca7080
Compare
bca7080
to
d319511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and I think the dist
output is looking even more tidy (to me, at least!)
d319511
to
329dc67
Compare
Description
Reducing whitespace in our CSS files (especially var functions) optimizes them for minification. This PR implements CSSNano for optimization and minification however CSS minifiers will not remove whitespace from var functions (as whitespace could be valid input) but prettier will. To this end, I've added prettier to the build process so that it will process the raw CSS coming in and then pass the pre-prettified version over to postcss which will handle minification.
This PR updates to the latest version of prettier. A significant CSS bug existed at 2.x where it would remove commas from the end of var functions: i.e.,
var(--spectrum-logical-transform,)
. That format is critical to defaulting the value correctly and cannot be removed from the resulting code. This bug does not occur at 3.x version of prettier.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Regression testing
Expect to see no VRT changes.
Validate:
To-do list