Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create issue templates #282

Merged
merged 8 commits into from
Sep 19, 2019
Merged

docs: create issue templates #282

merged 8 commits into from
Sep 19, 2019

Conversation

lazd
Copy link
Member

@lazd lazd commented Sep 17, 2019

Description

This PR adds issue templates:

  • Bug report
  • Feature request
  • Documentation issue
  • Support request

Related Issues

  • SDS-2241 Update CONTRIBUTING.md, ISSUE_TEMPLATE.md, and PULL_REQUEST_TEMPLATE.md

Motivation and Context

This will streamline issue reporting.

How Has This Been Tested?

We have to merge to master first before testing.

@lazd lazd changed the base branch from master to ccc September 17, 2019 15:52
@lazd lazd mentioned this pull request Sep 17, 2019
5 tasks
@bernhard-adobe
Copy link
Contributor

maybe move all of the example descriptions you added in a comments block so there is never a chance it get's added to the PR by accident.

Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing a lot of inconsistencies with comment blocks for the templates.
I'd suggest to always use the comment blocks <!-- --> to avoid the accidental adding of template text.
I would also suggest that our content strategist Jess takes a look at this. She might have very valuable feedback.

@@ -0,0 +1,36 @@
---
name: "🐛Bug report"
about: Report a problem with Spectrum CSS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just "report a bug"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It renders like this, so I think Bug report with the description works well here:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah cool to see the context! this might make it more consistent.



## Steps to reproduce

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like URL?
Those will be very useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. That's what I meant with Go to '...', I will make that more clear

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could pre-fill a URL in markdown there [URL](https://adobe.com) and make it even easier.

@@ -0,0 +1,20 @@
---
name: "✨Feature request"
about: Suggest an idea for this project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest a feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, idea seems a bit out of place.


---

## Is your feature request related to a problem?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why describe it as a question? Is this a check for them?
Why not "## Feature description"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I borrowed github's default template here... I thought this was a little weird as well. I'm +1 for Describe the feature in detail and any related problems it solves

## Is your feature request related to a problem?
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

## Describe the solution you'd like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of the same like "Feature description"

## Describe the solution you'd like
A clear and concise description of what you want to happen.

## Describe alternatives you've considered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you need to describe alternatives?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be something like

Currently, I have to do step 1 and step 2 to achieve my goal, but with this feature, it would be only one step

## Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

## Additional context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe ## Additional context and screenshots

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the line below covers screenshots, I'll make it a comment like the other files.

@lazd
Copy link
Member Author

lazd commented Sep 19, 2019

I just got final sign-off from Jess in content strategy on these templates. @bernhard-adobe, can you merge this?

@bernhard-adobe bernhard-adobe merged commit 4a7c0e2 into ccc Sep 19, 2019
@lazd lazd deleted the issue-templates branch September 19, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants