fix(picker): update S2 border-color [SWC-641]

[blunteshwar]

Description

Updated border-color tokens for picker.
https://jira.corp.adobe.com/browse/SWC-641

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Include steps for the PR reviewer that explain how they should test your PR. Example test outline:

1. Open the storybook for the picker component:
2. • Open the picker and validate that the border color is var(--spectrum-gray-800) using inspect element by searching for --system-picker-border-color-default-open
3. • Click the button and validate the new default open border-color is var(--spectrum-gray-800) and applied [@castastrophe]
4. • Open the picker and validate that the border-color of open not hover variant is var(--spectrum-gray-900) using inspect element by searching for --system-picker-border-color-default-open: @marissahuysentruyt
5. • Open the picker and validate that the background-color of open not hover variant is var(--spectrum-gray-200) using inspect element by searching for --system-picker-background-color-default-open @marissahuysentruyt

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

4. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

The one on the top is with --system-picker-border-color-default-open: var(--spectrum-gray-800) (Desired)
The one on the bottom is with --system-picker-border-color-default-open: var(--spectrum-gray-500) (Current)

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• I have tested these changes in Windows High Contrast mode.
• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

🦋 Changeset detected

Latest commit: 7f4d9f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@spectrum-css/picker	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

File metrics

Summary

Total size: 2.25 MB^*

Package	Size	Minified	Gzipped
picker	28.19 KB	26.91 KB	3.38 KB

picker

Filename	Head	Minified	Gzipped	Compared to base
index-base.css	27.21 KB	25.98 KB	3.30 KB	-
index-theme.css	1.84 KB	1.80 KB	0.57 KB	-
index.css	28.19 KB	26.91 KB	3.38 KB	🔴 ⬆ 0.02 KB
metadata.json	14.93 KB	-	-	-
themes/express.css	1.45 KB	1.41 KB	0.55 KB	-
themes/spectrum-two.css	1.57 KB	1.53 KB	0.57 KB	🔴 ⬆ 0.02 KB
themes/spectrum.css	1.56 KB	1.51 KB	0.57 KB	-

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[github-actions]

🚀 Deployed on https://pr-3584--spectrum-css.netlify.app

[castastrophe]

Please update the changeset as described and update with the latest to resolve the conflict in the spectrum-two file.

[castastrophe]

This needs to be more detailed about what properties were specifically updated and what the impact might be for consumers.

[Rajdeepc]

@castastrophe I have added a couple of more design review updates for background color and border color for open not hover variant added in the validation steps 4 and 5. Kindly review before merging

[marissahuysentruyt]

Looks good to me! Thanks 🥳

[marissahuysentruyt]

@Rajdeepc Should we add a quick note here about the background color update for the s2 theme?