Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actiongroup wrapping, fixes #749 #775

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

bernhard-adobe
Copy link
Contributor

Original PR from @Martskin . Thank you very much for your contribution.
I am re-creating this PR so we can have the Visual Regression Testing handled by Jenkins. Unfortunately we don't don't support that yet on forks.

Original PR description from #758:
This PR modifies the CSS of ActionGroup to add top (block start) and right (inline-end) margins to fix the wrapping issue reported in Issue #749

Description

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

https://user-images.githubusercontent.com/3717760/85166502-3bc7ce00-b21c-11ea-8a22-01809ea7dbff.png
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@bernhard-adobe bernhard-adobe added bug Results from a bug in the CSS implementation testing labels Jul 28, 2020
@bernhard-adobe bernhard-adobe requested a review from GarthDB July 28, 2020 23:53
@bernhard-adobe bernhard-adobe force-pushed the fix-actiongroup-wrapping branch from 1589632 to 8b654b7 Compare July 29, 2020 20:48
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@Martskin
Copy link
Contributor

Original PR from @Martskin . Thank you very much for your contribution.
I am re-creating this PR so we can have the Visual Regression Testing handled by Jenkins. Unfortunately we don't don't support that yet on forks.

Glad to help! Let me know if there's anything else I can do on this.

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@bernhard-adobe bernhard-adobe merged commit 0b2064c into main Jul 31, 2020
@bernhard-adobe bernhard-adobe deleted the fix-actiongroup-wrapping branch July 31, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants