-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dataset discovery from event #425
Comments
Can you share some background why you want to encode the target dataset (which is specific to Adobe Cloud Platform) in the Experience Event ? Encoding such an information in the event creates a pretty tight coupling. |
Exactly my concern, @fmeschbe . If this is XC specific, then it needs to go into an extension schema and then merged/combined with experienceEvent at runtime. |
@rkpandey @fmeschbe @lrosenthol We have a related bit of metadata that is the datasource, which is used to identify the system that mastered the data originally. I think "datasource" is a good name for that case. In this case "dataset" has a good general meaning in that it describes a set of records that have common schemas and consistent meaning. So I think the meaning is good generically(Adobe is not the only potential implementor that will want to use this property) as is the naming. The description is something that needs to reflect this better. I will propose a new naming in the PR. |
Thanks @cdegroot-adobe. Let me try to disect to see, whether I understand this. And I am going to use less generic terminology from traditional databases: database and table and row and column and field.
Is it correct to say, that this property comes into play when tables are merged into a new table to indicate the name of the original table before the merge. Correct ? What if that resulting table is further merged ? Is that property to be filled by the original Event sender ? Or is it auto-filled by the process which stores the event in the first table ? The first option would create the coupling I was mentioning above, the second option would be a by-product of storing the event in the table. Neither is good; the former definitely worse, of course. I think it should actually be a third option: As tables are merged, this field should be added into the merged table. |
@fmeschbe The intent is the second option "auto-filled by the process which stores the event in the first table". It may do this on read rather than write, but that is an implementation detail. |
@fmeschbe - Any further thoughts on this? We need to get this into the July 16th milestone, so I would like to make a decision asap on a standard XDM property or an Adobe Extension. I prefer the former and see the general utility of this in non-adobe cases. But given time constraints I can go with the extension if others are not of the same mind set. |
Changed to an extension. Should be ready for merge now. |
Thanks @cdegroot-adobe, that helps me. And I am now +1 in general. I see you changed it to be an extension in PR #426. Fine for me. Thanks. |
PR #426 is merged, so let's close this issue as well. |
What are the schemas that are affected by the issue
context/ExperienceEvent
What are examples of products that are impacted by the issue
ACP
Requirement is to discover the dataset id to disambiguate un-normalized xdm attributes.
The text was updated successfully, but these errors were encountered: