add dataset id as part of event #426
Conversation
| "xdm:datasetID": { | ||
| "title": "Dataset ID", | ||
| "type": "string", | ||
| "description": "System generated identifier for the Dataset the event belongs to." |
There was a problem hiding this comment.
What is a Dataset? Is it Adobe specific or something general?
There was a problem hiding this comment.
Yes, this is Adobe Experience Cloud specific.
There was a problem hiding this comment.
Proposed change to description:
From:"System generated identifier for the Dataset the event belongs to."
To:"Identifier of the originating Dataset the Experience Event record belongs to. Used to associate Dataset metadata with records in cases where multiple Datasets are being merged."
|
I think this PR is pretty straight forward. But we should discuss the merit of this PR in the linked issue #425 |
|
@fmeschbe @lrosenthol I have changed this to be a extension as that was the general consensus. It is a fairly simple update. Please let me know is there are any further open items. As this resolves the comments we will look to merge this in tomorrow. |
| @@ -44,7 +44,7 @@ | |||
| "title": "End User IDs", | |||
| "$ref": "https://ns.adobe.com/xdm/context/enduserids", | |||
| "description": | |||
| "Condensed, normalized encapsulation of all end user identifiers.\n" | |||
| "Condensed, normalized encapsulation of all end user identifiers." | |||
There was a problem hiding this comment.
Looks like this is an formatting change which slipped into this PR. I think we should steer clear from such side-cars in the future. For now, I think we can let that pass.
Please link to the issue #…
#425