Feature/separate prefixsearch #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 9, 2023 07:33
…n adapter that makes it look like a dictionary
…gument so it matches Julia standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the Direct sampler and pulls out its prefix-search algorithm, also known as a scan algorithm, which is responsible for maintaining the sum of hazards while the hazards themselves can be disabled or changed. This PR creates a new algorithm I call a Keyed Prefix Search, which is a prefix search with a dictionary-like interface. It turns out that's what we need, and it encapsulates different variants of prefix search. Those variants can, for instance, optimize for sampling just a few clocks, optimize for sampling a semi-infinite set of clocks, or optimize for clocks whose keys are from 1 to N, where N is fixed. The idea for users of this is to say what their code needs, and they will get the right implementation.