Add master to nested keys feature #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons#148) * Add option to skip validations on setting values * Rename option for skipping validation * Change object merge to use pureAssign * Update readme to reflect `skipValidate` option * Update helper to pass along `skipValidate` option
obj.hasOwnProerty(key) seems to be returning false for ember data models. key in obj seems to work for me.
* [BUG]: clear errors for ember 1.13.13 * Update index.js
* Added isValidating function to changeset * Added beforeValidation and afterValidation events * Updated README.md for isValidating and events * Update README.md * Update index.js
* update to ember-cli 2.8.0 * update to ember-cli 2.9.0 * update to ember-cli 2.10.1 * update to ember-cli 2.12.1 * remove bower from circle build * update ember-try configuration * remove bower install from circle setup ember-cli removed the bower.json file so running this step causes the tests to fail as it can't find the file. * add ember 1.13 back to try tests
steverhoades
pushed a commit
to steverhoades/ember-changeset
that referenced
this pull request
Oct 6, 2017
* Add option to skip validations when setting values (adopted-ember-addons#148) * Add option to skip validations on setting values * Rename option for skipping validation * Change object merge to use pureAssign * Update readme to reflect `skipValidate` option * Update helper to pass along `skipValidate` option * obj.hasOwnProperty(key) => key in obj (adopted-ember-addons#151) obj.hasOwnProerty(key) seems to be returning false for ember data models. key in obj seems to work for me. * [BUG]: clear errors for ember 1.13.13 (adopted-ember-addons#157) * [BUG]: clear errors for ember 1.13.13 * Update index.js * Released v1.2.3 * Added isValidating and events (adopted-ember-addons#152) * Added isValidating function to changeset * Added beforeValidation and afterValidation events * Updated README.md for isValidating and events * Update README.md * Update index.js * Update ember and friends (adopted-ember-addons#165) * update to ember-cli 2.8.0 * update to ember-cli 2.9.0 * update to ember-cli 2.10.1 * update to ember-cli 2.12.1 * remove bower from circle build * update ember-try configuration * remove bower install from circle setup ember-cli removed the bower.json file so running this step causes the tests to fail as it can't find the file. * add ember 1.13 back to try tests * add yarn lock file for yarn support (adopted-ember-addons#164) * allow empty objects (adopted-ember-addons#166)
steverhoades
pushed a commit
to steverhoades/ember-changeset
that referenced
this pull request
Oct 6, 2017
* Add option to skip validations when setting values (adopted-ember-addons#148) * Add option to skip validations on setting values * Rename option for skipping validation * Change object merge to use pureAssign * Update readme to reflect `skipValidate` option * Update helper to pass along `skipValidate` option * obj.hasOwnProperty(key) => key in obj (adopted-ember-addons#151) obj.hasOwnProerty(key) seems to be returning false for ember data models. key in obj seems to work for me. * [BUG]: clear errors for ember 1.13.13 (adopted-ember-addons#157) * [BUG]: clear errors for ember 1.13.13 * Update index.js * Released v1.2.3 * Added isValidating and events (adopted-ember-addons#152) * Added isValidating function to changeset * Added beforeValidation and afterValidation events * Updated README.md for isValidating and events * Update README.md * Update index.js * Update ember and friends (adopted-ember-addons#165) * update to ember-cli 2.8.0 * update to ember-cli 2.9.0 * update to ember-cli 2.10.1 * update to ember-cli 2.12.1 * remove bower from circle build * update ember-try configuration * remove bower install from circle setup ember-cli removed the bower.json file so running this step causes the tests to fail as it can't find the file. * add ember 1.13 back to try tests * add yarn lock file for yarn support (adopted-ember-addons#164) * allow empty objects (adopted-ember-addons#166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #140, this brings in the most recent updates to master.